Hi Markus, On Tue, 12 Nov 2019 at 19:02, Denton Liu <liu.denton@xxxxxxxxx> wrote: > I see that you've sent many Coccinelle patches to the mailing list. It > might be better to send them all together as a single threaded patchset > so that reviewers will have an easier time finding all of them. FWIW, I had the same thought. > > This script contained two transformation rules for the semantic patch language > > which used duplicate code. > > Thus combine these rules by using a SmPL disjunction for the replacement > > of two identifiers. My knowledge of coccinelle and cocci rules is basically zero, but my impression from this list is that running "make coccicheck" can be expensive, both in terms of time and memory. Do these patches help there in any way? Or could they hurt? Martin
