Re: [PATCH 1/1] contrib: Add --recursive flag for bash completion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Junio,

On Wed, 13 Nov 2019, Junio C Hamano wrote:

> "James Shubin via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
>
> > From: James Shubin <james@xxxxxxxxx>
> > Subject: Re: [PATCH 1/1] contrib: Add --recursive flag for bash completion
>
> The title must make it clear which git subcommand learned the
> "--recursive" (unless the patch adds it to everything, that is).
>
>     Subject: [PATCH] completion: tab-complete "git svn --recursive"
>
> By the way, it is pointless to send a cover letter for a single
> patch topic like this; you may want to tell GGG not to do so.

In this instance, I totally agree. But in this instance, it would also
have made sense to at least scrub the PR description template before
sending. Also, it would have made sense to listen to Emily who suggested
to have another go at the commit message before sending.

Thanks,
Johannes




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux