On Thu, Nov 07, 2019 at 05:46:58PM +0000, Derrick Stolee via GitGitGadget wrote: > From: Derrick Stolee <dstolee@xxxxxxxxxxxxx> > > When writing a commit-graph, we show progress along several commit > walks. When we use start_delayed_progress(), the progress line will > only appear if that step takes a decent amount of time. > > However, one place was missed: computing generation numbers. This is > normally a very fast operation as all commits have been parsed in a > previous step. But, this is showing up for all users no matter how few > commits are being added. This part of the patch is a good thing, and obviously correct. But I wondered... > The tests that check for the progress output have already been updated > to use GIT_PROGRESS_DELAY=0 to force the expected output. However, there > is one test in t6500-gc.sh that uses the test_terminal method. This > mechanism does not preserve the GIT_PROGRESS_DELAY environment variable, Why doesn't GIT_PROGRESS_DELAY make it through? Overall it's not that big a deal to me if it doesn't, but in this test: > test_expect_success TTY 'with TTY: gc --no-quiet' ' > test_terminal git -c gc.writeCommitGraph=true gc --no-quiet >stdout 2>stderr && > test_must_be_empty stdout && > - test_i18ngrep "Enumerating objects" stderr && > - test_i18ngrep "Computing commit graph generation numbers" stderr > + test_i18ngrep "Enumerating objects" stderr > ' We're not actually checking anything related to gc.writeCommitGraph anymore. > so we need to modify check on the output. We still watch for the Minor typo: s/modify/& the/ or similar? -Peff
