Re: [PATCH 2/5] doc: reset: unify <pathspec> description

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alexandr Miloslavskiy <alexandr.miloslavskiy@xxxxxxxxxxx> writes:

>> It is not quite the opposite of adding to the index from the working
>> tree.  In this sequence:
>>
>> 	$ edit newfile
>> 	$ git add newfile
>>
>> and then further
>>
>> 	$ edit newfile
>> 	$ git add newfile
>> 	$ git reset -- newfile
>>
>> we are taken back to the state _before_ any of the changes made to
>> newfile (in fact, since HEAD does not have newfile, the resulting
>> index would not know about it, either).
>
> I am a bit confused, is it correct that you don't expect me to change
> my patches?

I do not know if removal of the only-half-correct "This is the
opposite of add" should be part of this change, or it should be a
separate fix.  The half-wrong sentene was not introduced by this
patch, so leaving it as-is is OK.  It just leaves another thing for
us to think about later.

Thanks.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux