Hi! Thanks for all the feedback. On Wed, Nov 6, 2019 at 1:36 PM Jonathan Tan <jonathantanmy@xxxxxxxxxx> wrote: > > > > Also, clarify in the commit message somewhere that this commit does not > > > change the behavior of "git bisect". > > > > s/\.$/ when used without the "--first-parent" option&/; you mean? > > As far as I know, "git bisect" doesn't support --first-parent, whether > before or after this patch. Correct, it still provides the usual "usage: git bisect ..." error. This provides plumbing but no porcelain right now. > At first I thought that this patch also teaches "git bisect" to support > "--first-parent", but that is not the case. Only "git rev-list" learns > to make "--bisect" work with "--first-parent". So I wanted the > clarification. (But if you think that the clarification is unnecessary, > that's fine too.) I had been trying to deduce the best approach for writing the commit message but in the end I retained a hunch that I didn't yet know enough to write the best one so this conversation is quite illuminating re: commit style. If it's even slightly confusing I would like to clarify, since bisect.c and git bisect are... very different! I think Dscho's recommendation also will result in the patch overall being far more lucid.
