Re: [PATCH] Make verify-tag a builtin.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2007/7/23, Johannes Schindelin <Johannes.Schindelin@xxxxxx>:
On Mon, 23 Jul 2007, Carlos Rica wrote:
> +static int run_gpg_verify(const char *buf, unsigned long size, int verbose)
> +{
> +     struct child_process gpg;
> +     const char *args_gpg[] = {"gpg", "--verify", "FILE", "-", NULL};
> +     char *path, *eol;
> +     size_t len;
> +     int fd, ret;
> +
> +     path = xstrdup(git_path("VTAG_TMP"));
> +     fd = open(path, O_CREAT | O_TRUNC | O_WRONLY, 0600);
> +     if (fd < 0)
> +             return error("could not create temporary file '%s': %s",
> +                                             path, strerror(errno));
> +     if (write_in_full(fd, buf, size) < 0)
> +             return error("failed writing temporary file '%s': %s",
> +                                             path, strerror(errno));
> +     close(fd);

I just tested something like "gpg --verify - - < <filename>" and it
worked...

I couldn't verify tags using "gpg --verify  -  -  <file" as you
pointed in your response.

In my tests, it only allowed me to run:
"gpg --verify file.asc" or
"gpg --verify <file.asc" or
"gpg --verify - <file.asc"
when file.asc was generated using the command "gpg --clearsign file",
in which it inserts a header:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
<empty-line>

I even tested to insert the header myself after creating a signed file
as git does:
  cp file otherfile
  gpg -bsa otherfile
  ...
  cat otherfile.asc >>otherfile
  ( echo -e "-----BEGIN PGP SIGNED MESSAGE-----\nHash: SHA1\n" ; cat
otherfile ) \
    | gpg --verify

Note that sending them to "diff file.asc -" also shows different signatures,
but anyway it also says "gpg: BAD signature from ...", the same message as in:
  gpg --verify - - <otherfile

and different from the "gpg: Good signature from ..." when I run:
 gpg --verify file.asc
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux