"brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes: > On 2019-11-06 at 01:58:33, Junio C Hamano wrote: >> Jeff King <peff@xxxxxxxx> writes: >> >> > Thanks. I think this is an improvement over v1, but I'm still a little >> > iffy on some of the other movement in the first patch. >> > >> > TBH, I don't think it's making anything _worse_, but I think it >> > highlights how some of our documentation is a mish-mash of low-level and >> > high-level details. ;) So it might be a good opportunity to at least >> > clean up the documentation around ident environment variables. >> >> Yeah, I hate to suggest another round, but agree with your comments >> on 1/4 wrt the way how and the place where the environment variables >> are explained, which invalidates the changes in 2/4. Fortunately >> 3/4 and 4/4 are unaffected ;-) > > Yeah, I agree another round is warranted, and it's not the end of the > world: it'll get into 2.25 either way. I'll try to get a reroll out in > the next few days. Thanks. I also agree with what Peff and you said on 3/4 wrt the addition of "ship template, tweak it into an untracked config that gets used".
