Fix the LGTM warning of the rule that finds uses of the assignment
operator = in places where the equality operator == would
make more sense.
Signed-off-by: Elia Pinto <gitter.spiros@xxxxxxxxx>
---
ident.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/ident.c b/ident.c
index e666ee4e59..07f2f03b0a 100644
--- a/ident.c
+++ b/ident.c
@@ -172,12 +172,15 @@ const char *ident_default_email(void)
strbuf_addstr(&git_default_email, email);
committer_ident_explicitly_given |= IDENT_MAIL_GIVEN;
author_ident_explicitly_given |= IDENT_MAIL_GIVEN;
- } else if ((email = query_user_email()) && email[0]) {
- strbuf_addstr(&git_default_email, email);
- free((char *)email);
- } else
- copy_email(xgetpwuid_self(&default_email_is_bogus),
+ } else {
+ email = query_user_email();
+ if (email && email[0]) {
+ strbuf_addstr(&git_default_email, email);
+ free((char *)email);
+ } else
+ copy_email(xgetpwuid_self(&default_email_is_bogus),
&git_default_email, &default_email_is_bogus);
+ }
strbuf_trim(&git_default_email);
}
return git_default_email.buf;
--
2.24.0.rc0.467.g566ccdd3e4.dirty
