Hi Peff, On Thu, 31 Oct 2019, Jeff King wrote: > On Wed, Oct 30, 2019 at 09:54:52AM +0100, Johannes Schindelin wrote: > > > > One non-bikeshed question: would fprintf() on some platforms have sent > > > "\r\n", which is no longer happening with our write()? Do we need to > > > care about that? > > > > I am not aware of any platform where `fprintf()` would automatically > > transform `\n` to `\r\n`. Not unless the `FILE *` in question has been > > opened with the `t` flag. And I am rather certain that `stderr` is not > > opened with that flag. And if it was, I would force it off in Git for > > Windows. > > OK, thanks. You guessed the platform I was thinking of. :) > > Another more far-fetched one: IIRC our stdio wrappers on Windows do some > magic to convert ANSI color codes into actual terminal codes. Could that > be a problem here? I think we'd kill off any color codes in the actual > message due to the control-code replacement. In theory the prefix could > have them. I don't think any code does now, but the PUSH_COLOR_ERROR > stuff in builtin/push.c is getting close. I wouldn't be surprised for > that to eventually get folded into error(). A valid concern! As per eac14f8909d (Win32: Thread-safe windows console output, 2012-01-14), `write()` _implicitly_ gets the ANSI emulation of `winansi.c`. So I think we're good. Thanks for thinking of all kinds of angles, Dscho
