Re: [PATCH v3] submodule: teach set-url subcommand

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Denton Liu <liu.denton@xxxxxxxxx> writes:

> Currently, in the event that a submodule's upstream URL changes, users
> have to manually alter the URL in the .gitmodules file then run
> `git submodule sync`. Let's make that process easier.

Right now, submodule.<name>.url might be the only thing that gets
synched down to .git/config of the submodule; we may not learn any
more things that needs "edit in .gitmodules and then run sync".  Can
we sately say that "sync" is now obsolete and what it has been used
for can now be done with "set-url"?  In other words, does "set-url"
makes "sync" unnecessary and deprecated?

Or is it expected that we would learn more things end users can edit
in .gitmodules and run sync to propagate necessary pieces of
information down?  If so, do we want to add an extra command like
set-url for each of these new things, or do we tell users "if you
are editing url, use set-url, otherwise edit .gitmodules and run
sync"?  If the former, that would make the set of subcommands quite
noisy, and if the latter, the users need to learn two things,
i.e. it is not making it easier but harder to learn the system.

There is nothing _wrong_ to introduce the new subcommand per-se, but
given that the URL should not change that often, and due to above
concerns, I am not sure if I want to back this change.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux