"Johannes Schindelin via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > From: Johannes Schindelin <johannes.schindelin@xxxxxx> > > When calling `git stash` while changes were staged for files that are > marked with the `skip-worktree` bit (e.g. files that are excluded in a > sparse checkout), the files are recorded as _deleted_ instead. Good. Much easier to see what is going on than the verb "lose" used in the cover letter of v1 that puzzled me. > However, when the temporary index is updated via `git update-index --add > --remove`, skip-worktree entries mark the files as deleted by mistake. > > Let's use the newly-introduced `--ignore-skip-worktree-entries` option > of `git update-index` to prevent exactly this from happening. Good. > Note that the regression test case deliberately avoids replicating the > scenario described above and instead tries to recreate just the symptom. That's good. Testing the end-user visible effect is just as important as the narrowly pointed root-cause test like the one in the previous patch. Thanks.
