On 10/16/19 12:35 PM, William Baker via GitGitGadget wrote: > From: William Baker <William.Baker@xxxxxxxxxxxxx> > > The comments for the staging/unstaging test did not accurately > describe the scenario being tested. It is not essential that > the test files being staged/unstaged appear at the end of the > index. All that is required is that the test files are not > flagged with CE_FSMONITOR_VALID and have a position in the > index greater than the number of entries in the index after > unstaging. > > The comment for this test has been updated to be more > accurate with respect to the scenario that's being tested. > > Signed-off-by: William Baker <William.Baker@xxxxxxxxxxxxx> > --- > t/t7519-status-fsmonitor.sh | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/t/t7519-status-fsmonitor.sh b/t/t7519-status-fsmonitor.sh > index d8df990972..997d5fb349 100755 > --- a/t/t7519-status-fsmonitor.sh > +++ b/t/t7519-status-fsmonitor.sh > @@ -354,9 +354,11 @@ test_expect_success 'discard_index() also discards fsmonitor info' ' > test_cmp expect actual > ' > > -# Test staging/unstaging files that appear at the end of the index. Test > -# file names begin with 'z' so that they are sorted to the end of the index. > -test_expect_success 'status succeeds after staging/unstaging ' ' > +# Test unstaging entries that: > +# - Are not flagged with CE_FSMONITOR_VALID > +# - Have a position in the index >= the number of entries present in the index > +# after unstaging. > +test_expect_success 'status succeeds after staging/unstaging' ' > test_create_repo fsmonitor-stage-unstage && > ( > cd fsmonitor-stage-unstage && > Gentle ping on this patch. It's just a small update to the comments for an fsmonitor related test based on feedback I received in the segfault fix patch series [1]. Thanks, William [1] https://public-inbox.org/git/3d3b290c-bc15-4bd5-e0c0-1377c9ec3ff9@xxxxxxxxx/
