On Sun, Oct 27, 2019 at 09:20:24PM +0900, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > If somebody wants to pursue a patch, I suspect the solution is probably > > something like this (totally untested): > > Looks sensible. It is very much unsatisfying that datestamp(), > which is used by fmt_ident() when no date string is given, seems to > totally bypass date.c::get_time(), which means the framework to give > fake timestamp via GIT_TEST_DATE_NOW cannot be used to write > reproducible tests. > > Given that datestamp() is only used by the push certificate and > fast-import codepaths and nowhere else, I suspect that "fixing" it > retroactively to honor GIT_TEST_DATE_NOW would not have any negative > fallout, but that's not something I should be contemplating on > during the -rc period ;-) Yeah, I agree datestamp() should respect $GIT_TEST_DATE_NOW. This whole topic is not something for the -rc period, I would think. -Peff
