Re: [PATCH 1/2] update-index: optionally leave skip-worktree entries alone

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 1/2] update-index: optionally leave skip-worktree entries alone
From: Junio C Hamano <gitster@xxxxxxxxx>
Date: Tue, 29 Oct 2019 11:27:25 +0900
Cc: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx>, git@xxxxxxxxxxxxxxx, Johannes Schindelin via GitGitGadget <gitgitgadget@xxxxxxxxx>
In-reply-to: <nycvar.QRO.7.76.6.1910282206081.46@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Mon, 28 Oct 2019 22:07:15 +0100 (CET)")
References: <pull.355.git.gitgitgadget@gmail.com> <c263eb54b30b3e93abb74662d120d8bb882322bb.1569483748.git.gitgitgadget@gmail.com> <xmqq36fda3i8.fsf@gitster-ct.c.googlers.com> <nycvar.QRO.7.76.6.1910282206081.46@tvgsbejvaqbjf.bet>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:

>> Isn't this something reasonably easy to guard against regression with
>> a test or two?
>
> I sent out a v2 with tests added to 1/2.

Good; that way, not just "stash" but anything that relies on update-index
would be protected from regressions.

Thanks.

References:
- [PATCH 0/2] Fix git stash with skip-worktree entries
  - From: Johannes Schindelin via GitGitGadget
- [PATCH 1/2] update-index: optionally leave skip-worktree entries alone
  - From: Johannes Schindelin via GitGitGadget
- Re: [PATCH 1/2] update-index: optionally leave skip-worktree entries alone
  - From: Junio C Hamano
- Re: [PATCH 1/2] update-index: optionally leave skip-worktree entries alone
  - From: Johannes Schindelin

Prev by Date: Re: [PATCH v2 00/15] SHA-256 test fixes, part 6
Next by Date: Re: [PATCH v2] Documentation/git-bisect.txt: add --no-ff to merge command
Previous by thread: Re: [PATCH 1/2] update-index: optionally leave skip-worktree entries alone
Next by thread: [PATCH 2/2] stash: handle staged changes in skip-worktree files correctly
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]