Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > Hi, > > Emily Shaffer wrote: > >> Indicate that the user needs some dependencies before the build will run >> happily on their machine; this dependency list doesn't seem to be made >> clear anywhere else in the project documentation. > > In theory, this info should be in INSTALL. I wouldn't be surprised if > it's missing some info, though. > > [...] >> --- a/Documentation/MyFirstContribution.txt >> +++ b/Documentation/MyFirstContribution.txt >> @@ -38,6 +38,30 @@ $ git clone https://github.com/git/git git >> $ cd git >> ---- >> >> +[[dependencies]] >> +=== Installing Dependencies >> + >> +To build Git from source, you need to have a handful of dependencies installed >> +on your system. For a hint of what's needed, you can take a look at >> +`ci/install-dependencies.sh`. >> + >> +To install the dependencies needed for a basic build on Linux, run something >> +like this (or replace `apt` with your distribution's package manager of choice): > > pedantic nit: s/or replace/replacing/ ("or" would mean rpm is an > alternative to what came before, but "something like" in the phrase > before has rpm already included) This section, as you hinted at the beginning, should be a single sentence, i.e. just "follow INSTALL". Any clarifications should be made as a patch to the INSTALL file. Thanks.
