Re: [Outreachy][PATCH] abspath: reconcile `dir_exists()` and `is_directory()`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [Outreachy][PATCH] abspath: reconcile `dir_exists()` and `is_directory()`
From: Christian Couder <christian.couder@xxxxxxxxx>
Date: Sat, 26 Oct 2019 20:05:34 +0200
Cc: git <git@xxxxxxxxxxxxxxx>
In-reply-to: <CAN7CjDDr0vDBDi+RKA0BMTHSaVQofc=GTCEuy1mAOaQmVqhJXA@mail.gmail.com>
References: <20191024092745.97035-1-mirucam@gmail.com> <20191024114148.GK4348@szeder.dev> <xmqqmudpee57.fsf@gitster-ct.c.googlers.com> <CAN7CjDB9mRTNRKRoE8XfLz4in5gV6pxrKrqcjLPfthDHaf20nA@mail.gmail.com> <xmqqzhhpb1nx.fsf@gitster-ct.c.googlers.com> <CAP8UFD1_vnjApobt+aN3M12g8mLqOZJGyvr4oqqTax5=cmLhsg@mail.gmail.com> <CAN7CjDC169rv8p9ZJcoLMeisXh7eMVcE4_-bpz8XFiYUsWAakQ@mail.gmail.com> <CAN7CjDDr0vDBDi+RKA0BMTHSaVQofc=GTCEuy1mAOaQmVqhJXA@mail.gmail.com>

Hi Miriam,

On Sat, Oct 26, 2019 at 5:31 PM Miriam R. <mirucam@xxxxxxxxx> wrote:
>
> Dear all,
> there is already a static function called path_exists() in archive.c
> so project does not compile.
>
> Maybe we could change the name of this static function and its
> reference in archive.c like archive_path_exists() for example, or some
> other you find more suitable.

Yeah, I think renaming the function archive_path_exists() in a
preparatory patch would be a good way to move forward on this.

Best,
Christian.

Follow-Ups:
- Re: [Outreachy][PATCH] abspath: reconcile `dir_exists()` and `is_directory()`
  - From: Miriam R.

References:
- [Outreachy][PATCH] abspath: reconcile `dir_exists()` and `is_directory()`
  - From: Miriam Rubio
- Re: [Outreachy][PATCH] abspath: reconcile `dir_exists()` and `is_directory()`
  - From: SZEDER Gábor
- Re: [Outreachy][PATCH] abspath: reconcile `dir_exists()` and `is_directory()`
  - From: Junio C Hamano
- Re: [Outreachy][PATCH] abspath: reconcile `dir_exists()` and `is_directory()`
  - From: Miriam R.
- Re: [Outreachy][PATCH] abspath: reconcile `dir_exists()` and `is_directory()`
  - From: Junio C Hamano
- Re: [Outreachy][PATCH] abspath: reconcile `dir_exists()` and `is_directory()`
  - From: Christian Couder
- Re: [Outreachy][PATCH] abspath: reconcile `dir_exists()` and `is_directory()`
  - From: Miriam R.
- Re: [Outreachy][PATCH] abspath: reconcile `dir_exists()` and `is_directory()`
  - From: Miriam R.

Prev by Date: Re: GIT_COMMITTER_* and reflog
Next by Date: Re: RFC: Moving git-gui development to GitHub
Previous by thread: Re: [Outreachy][PATCH] abspath: reconcile `dir_exists()` and `is_directory()`
Next by thread: Re: [Outreachy][PATCH] abspath: reconcile `dir_exists()` and `is_directory()`
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]