On Thu, Oct 24, 2019 at 12:37:32PM +0900, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > ... > > The "seen" variant for this test mistakenly parsed another commit > > instead of the blob, meaning that we were actually just testing the > > "lone" case again. Changing that reveals the breakage (and shows that > > this fixes it). > > ... > > @@ -52,7 +52,7 @@ test_expect_success 'traverse unexpected non-commit parent (lone)' ' > > ' > > > > test_expect_success 'traverse unexpected non-commit parent (seen)' ' > > - test_must_fail git rev-list --objects $commit $broken_commit \ > > + test_must_fail git rev-list --objects $blob $broken_commit \ > > >output 2>&1 && > > test_i18ngrep "not a commit" output > > ' > > Yikes. Thanks for spotting. By the way, I shuffled this one to the front so that it could be taken separately for "maint" if you want (but it has been this way for at least a decade, so I don't think it's urgent for v2.24). -Peff
