On Tue, Oct 22, 2019 at 04:33:16PM -0400, Jeff King wrote: > > I have failed to produce a test using the file:// protocol that > > demonstrates this bug. > > Hmm, from the description, it sounds like it should be easy. I might > poke at it a bit. Hmph. I can reproduce it here, but it seems to depend on the repository. If I do this: diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh index ecabbe1616..8d473a456f 100755 --- a/t/t5510-fetch.sh +++ b/t/t5510-fetch.sh @@ -583,6 +583,14 @@ test_expect_success 'fetch.writeCommitGraph' ' ) ' +test_expect_success 'fetch.writeCommitGraph with a bigger repo' ' + git clone "$TEST_DIRECTORY/.." repo && + ( + cd repo && + git -c fetch.writeCommitGraph fetch origin + ) +' + # configured prune tests set_config_tristate () { it reliably triggers the bug. But if I make a synthetic repo, even it has a lot of commits (thousands or more), it doesn't trigger. I thought maybe it had to do with having commits that were not at tips (since the tip ones presumably _are_ fed into the graph generation process). But that doesn't seem to help. Puzzling... -Peff