On Tue, Oct 22, 2019 at 04:49:19AM +0900, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > >> ... I do not particularly see this change (there may be similar > >> ones) desirable. I'd find it it be much more natural to sort > >> "commit-anything" after "commit", and that is true with or without > >> the common extension ".o" added to these entries. > >> > >> In short, flipping these entries because '.' sorts later than '-' is > >> making the result look "less sorted", at least to me. > > > > The problem with this argument is that it disagrees with ASCII, as `-` > > has code 0x2d while `.` has code 0x2e, i.e. it is lexicographically > > _larger_. > > I am saying that sorting these in ASCII order did not produce result > that is easy to the eyes. > > You are saying that Denton's patch sorted these lines in ASCII order. > > I agree with you that it did correctly sort them in ASCII order. > > That does not make the patch right ;-) What's the purpose of sorting them, though? I thought it was less for aesthetics and more to to keep lines deterministic (to avoid two branches adding the same line in different places, thus causing weirdness when the two are merged). In that case, I think we care less about the exact order and more that anybody can easily reproduce the same sort (by running "10:!sort" or whatever you weird emacs-types would type). -Peff
