Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote:
>
> There is some funny code generation going on to make the context menu,
> and the messages for this have to be doubly quoted.
>
> Noticed by Harri Ilari Tapio Liusvaara
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
> ---
> git-gui.sh | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
I'll try to rewrite this hunk as a procedure, to get rid of the
double evaluation problem. However...
> diff --git a/git-gui.sh b/git-gui.sh
> index 075a2b9..52170ee 100755
> --- a/git-gui.sh
> +++ b/git-gui.sh
> @@ -2457,9 +2457,9 @@ bind_button3 $ui_diff "
> set cursorX %x
> set cursorY %y
> if {\$ui_index eq \$current_diff_side} {
> - $ctxm entryconf $ui_diff_applyhunk -label [mc {Unstage Hunk From Commit}]
> + $ctxm entryconf $ui_diff_applyhunk -label \"[mc "Unstage Hunk From Commit"]\"
That's the wrong change to do here, as you are going to eval
the result of the translation. If the translation had a Tcl
special character (\, $, [) in it then we'd actually execute that.
Instead the [ should be escaped:
> + $ctxm entryconf $ui_diff_applyhunk -label \[mc "Unstage Hunk From Commit"\]
But you aren't a Tcl programmer, so its OK. ;-)
--
Shawn.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
