Re: [PATCH v3 01/13] graph: automatically track display width of graph lines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v3 01/13] graph: automatically track display width of graph lines
From: Junio C Hamano <gitster@xxxxxxxxx>
Date: Wed, 16 Oct 2019 14:10:56 +0900
Cc: git@xxxxxxxxxxxxxxx, James Coglan <jcoglan@xxxxxxxxx>
In-reply-to: <xmqq8spl9xcd.fsf@gitster-ct.c.googlers.com> (Junio C. Hamano's message of "Wed, 16 Oct 2019 12:35:14 +0900")
References: <pull.383.v2.git.1571182864.gitgitgadget@gmail.com> <pull.383.v3.git.1571183279.gitgitgadget@gmail.com> <722ab8973ace92aeef8669eced2919a144240cc0.1571183279.git.gitgitgadget@gmail.com> <xmqq8spl9xcd.fsf@gitster-ct.c.googlers.com>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Junio C Hamano <gitster@xxxxxxxxx> writes:

>>  int graph_next_line(struct git_graph *graph, struct strbuf *sb)
>
> I just noticed it but does this have to be extern?  Nobody outside
> graph.[ch] seems to have any reference to it.

I was stupid; strike this part out.

Thanks.

References:
- [PATCH v2 00/13] Improve the readability of log --graph output
  - From: James Coglan via GitGitGadget
- [PATCH v3 00/13] Improve the readability of log --graph output
  - From: James Coglan via GitGitGadget
- [PATCH v3 01/13] graph: automatically track display width of graph lines
  - From: James Coglan via GitGitGadget
- Re: [PATCH v3 01/13] graph: automatically track display width of graph lines
  - From: Junio C Hamano

Prev by Date: Re: [RFC PATCH 1/1] Teach remote add the --prefix-tags option
Next by Date: Re: [PATCH 1/1] notes: copy notes to HEAD by default
Previous by thread: Re: [PATCH v3 01/13] graph: automatically track display width of graph lines
Next by thread: [PATCH v3 04/13] graph: reduce duplication in `graph_insert_into_new_columns()`
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]