Hey, Today I've spent a few hours to understand why git-completion doesn't work in my zsh shell. It was because I thought ~/.zsh/_git should be a dictionary with git-completion.zsh file. I think this change may save some hours for someone else. Maxim Belsky (1): doc: Change zsh git completion file name contrib/completion/git-completion.zsh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) base-commit: 108b97dc372828f0e72e56bbb40cae8e1e83ece6 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-367%2Fmbelsky%2Fpatch-1-v3 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-367/mbelsky/patch-1-v3 Pull-Request: https://github.com/gitgitgadget/git/pull/367 Range-diff vs v2: 1: 3f994f3b9a ! 1: 7919addea8 doc: Change zsh git completion file name @@ -8,9 +8,10 @@ There is a small update to clarify it. - Signed-off-by: Maxim Belsky <public.belsky@xxxxxxxxx> Helped-by: Johannes Schindelin <Johannes.Schindelin@xxxxxx> Helped-by: Junio C Hamano <gitster@xxxxxxxxx> + Helped-by: SZEDER Gábor <szeder.dev@xxxxxxxxx> + Signed-off-by: Maxim Belsky <public.belsky@xxxxxxxxx> diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh --- a/contrib/completion/git-completion.zsh @@ -22,8 +23,8 @@ -# The recommended way to install this script is to copy to '~/.zsh/_git', and -# then add the following to your ~/.zshrc file: +# The recommended way to install this script is to make a copy of it in -+# ~/.zsh/ directory as ~/.zsh/git-completion.zsh and then add the following -+# to your ~/.zshrc file: ++# '~/.zsh/' directory as '~/.zsh/_git' and then add the following to your ++# ~/.zshrc file: # # fpath=(~/.zsh $fpath) -- gitgitgadget