On 2019-10-09 at 02:19:47, Junio C Hamano wrote: > I think we have been happy with (1) a comment at the end of the log > message that says X worked together with Y and Z to produce this > patch, and (2) the trailer block that has S-o-b: from X, Y and Z, > without any need for Co-authored-by: trailer so far, and I do not > see any reason to change it in this project. > > If other projects wants to use such a footer, that's their choice, > but I am fairly negative to the idea to open the gate to unbounded > number of new options for new trailer lines. We do not even have > such options like --acked=<acker>, --reported=<reporter>, for the > trailers that are actively used already (and to make sure nobody > misunderstands, I do not think it is a good idea to add such > individual options). If we don't want to add this option explicitly, which I understand, it may be useful to add an option to add arbitrary commit trailers to a commit message when creating it. Git uses a patch-based workflow, where adding trailers is relatively easy, but for folks using pull request-based workflows without signoffs, using Co-authored-by can be a great way to note when folks have worked together on a patch. An option to git commit such as --trailer would allow folks to add whatever trailers they wish, including this one, without us needing to bless particular options. I, for one, would be excited to see a series which did this. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204
Attachment:
signature.asc
Description: PGP signature
