This series of patches fixes the flags --edit and --no-edit. Currently, --no-edit has no effect. These patches implement the following behaviour: - when --edit is provided, the editor will always be opened; - when --no-edit is provided, the editor will not be opened (if possible), otherwise an error message will be displayed; - when neither --edit nor --no-edit are provided, the editor is opened only if a message is not provided and there isn't a previous tag message. In the future, the fix of these flags and the code factoring done in this patchset will be used on the implementation of a new flag --amend, as discussed on the mail thread started on https://public-inbox.org/git/CAHd499BM6M+=zRE1WFVXr7b+VhJHFeDind5xLqXcwZLv7QeDvw@xxxxxxxxxxxxxx/. Lucas Oshiro (3): tag: factor out tag reading from write_tag_body() tag: factor out prepare tag template code tag: add full support for --edit and --no-edit builtin/tag.c | 123 ++++++++++++++++++++++++++++++++++--------------- t/t7004-tag.sh | 4 +- 2 files changed, 88 insertions(+), 39 deletions(-) -- 2.23.0
