On 07/10/19 06:52PM, Birger Skogeng Pedersen wrote:
> So I kinda got this working, but only when focusing the commit message widget.
Isn't this the point of your feature? You change the view when focusing
the commit message widget. I remember you were explicitly against doing
it as soon as all unstaged files were staged. Did you change your point
of view on that?
> I did not manage to get it working when invoking "do_add_all", (e.g.
> when pressing CTRL/CMD+i). I added this:
>
> bind $ui_comm <$M1B-Key-i> {do_add_all;select_staged_file;break}
> bind $ui_comm <$M1B-Key-I> {do_add_all;select_staged_file;break}
>
> But it seems that the "select_staged_file" procedure is invoked
> _before_ "do_add_all" finishes. So that's not working. All changes
> gets staged, but no staged change is selected.
Hmm, that shouldn't happen. select_staged_file should be executed
_after_ do_add_all, not before. I haven't looked into your patches yet
though.
> And I'm quite stuck. Do I send the unfinished patch, so maybe I can
> get some advice? Or is it better to just wait until I have the perfect
> patch ready?
If you are stuck on something, and want to share the WIP feature to get
help/comments, you should mark your patches as "RFC" (Request For
Comments). This can be done by passing the option '-rfc' to
`git-format-patch`. This will make your subject prefix to "RFC PATCH"
instead of just "PATCH".
And yes, it is perfectly OK to send incomplete changes as long as you
mark them as such, and specify what you need help with.
But I see that you have already sent those patches. I'm not sure when I
can find time to tinker around with them, so it might take me a couple
of days to get to them.
--
Regards,
Pratyush Yadav
