Currently, the tests for GIT_SKIP_TESTS do not cover the situation where
we skip an entire test suite. The tests also do not cover the situation
where we have GIT_SKIP_TESTS defined but the test suite does not match.
Add two test cases so we cover this blindspot.
Signed-off-by: Denton Liu <liu.denton@xxxxxxxxx>
---
Changes since v1:
* Added another test case to cover the blindspot where GIT_SKIP_TESTS is
defined but the test suite does not match.
Range-diff against v1:
1: 08273a0d0d ! 1: b5f3af8a63 t0000: cover GIT_SKIP_TESTS blindspot
@@ Metadata
Author: Denton Liu <liu.denton@xxxxxxxxx>
## Commit message ##
- t0000: cover GIT_SKIP_TESTS blindspot
+ t0000: cover GIT_SKIP_TESTS blindspots
Currently, the tests for GIT_SKIP_TESTS do not cover the situation where
- we skip an entire test suite. Add a test case so we cover this
- blindspot.
+ we skip an entire test suite. The tests also do not cover the situation
+ where we have GIT_SKIP_TESTS defined but the test suite does not match.
+
+ Add two test cases so we cover this blindspot.
## t/t0000-basic.sh ##
@@ t/t0000-basic.sh: test_expect_success 'GIT_SKIP_TESTS sh pattern' "
@@ t/t0000-basic.sh: test_expect_success 'GIT_SKIP_TESTS sh pattern' "
+ EOF
+ )
+"
++
++test_expect_success 'GIT_SKIP_TESTS does not skip unmatched suite' "
++ (
++ GIT_SKIP_TESTS='notgit' && export GIT_SKIP_TESTS &&
++ run_sub_test_lib_test git-skip-tests-unmatched-suite \
++ 'GIT_SKIP_TESTS does not skip unmatched suite' <<-\\EOF &&
++ for i in 1 2 3
++ do
++ test_expect_success \"passing test #\$i\" 'true'
++ done
++ test_done
++ EOF
++ check_sub_test_lib_test git-skip-tests-unmatched-suite <<-\\EOF
++ > ok 1 - passing test #1
++ > ok 2 - passing test #2
++ > ok 3 - passing test #3
++ > # passed all 3 test(s)
++ > 1..3
++ EOF
++ )
++"
+
test_expect_success '--run basic' "
run_sub_test_lib_test run-basic \
t/t0000-basic.sh | 38 ++++++++++++++++++++++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
index 4c01f60dd3..4d3f7ba295 100755
--- a/t/t0000-basic.sh
+++ b/t/t0000-basic.sh
@@ -391,6 +391,44 @@ test_expect_success 'GIT_SKIP_TESTS sh pattern' "
)
"
+test_expect_success 'GIT_SKIP_TESTS entire suite' "
+ (
+ GIT_SKIP_TESTS='git' && export GIT_SKIP_TESTS &&
+ run_sub_test_lib_test git-skip-tests-entire-suite \
+ 'GIT_SKIP_TESTS entire suite' <<-\\EOF &&
+ for i in 1 2 3
+ do
+ test_expect_success \"passing test #\$i\" 'true'
+ done
+ test_done
+ EOF
+ check_sub_test_lib_test git-skip-tests-entire-suite <<-\\EOF
+ > 1..0 # SKIP skip all tests in git
+ EOF
+ )
+"
+
+test_expect_success 'GIT_SKIP_TESTS does not skip unmatched suite' "
+ (
+ GIT_SKIP_TESTS='notgit' && export GIT_SKIP_TESTS &&
+ run_sub_test_lib_test git-skip-tests-unmatched-suite \
+ 'GIT_SKIP_TESTS does not skip unmatched suite' <<-\\EOF &&
+ for i in 1 2 3
+ do
+ test_expect_success \"passing test #\$i\" 'true'
+ done
+ test_done
+ EOF
+ check_sub_test_lib_test git-skip-tests-unmatched-suite <<-\\EOF
+ > ok 1 - passing test #1
+ > ok 2 - passing test #2
+ > ok 3 - passing test #3
+ > # passed all 3 test(s)
+ > 1..3
+ EOF
+ )
+"
+
test_expect_success '--run basic' "
run_sub_test_lib_test run-basic \
'--run basic' --run='1 3 5' <<-\\EOF &&
--
2.23.0.248.g3a9dd8fb08
