> >> ... > >> Luke, does this look good? > >> > >> I know Mazo is the only other contributor who has multiple commits > >> to git-p4.py in the past 2 years, to make Reviewed-by carry some > >> weight ;-) but as we have so small number of people touching this > >> script anyway, I'd rather see what the main contributor in the past > >> 2 years thinks. > > > > I think it looks reasonable. > > > > Ack. > > Junio, does Philip need to resend a v3 with Luke's ack or will you just add it yourself while queuing the patch? > (sorry, if you already picked up the patch -- I just didn't see it in the last What's cooking update) Sorry, I do not recall the details of this old a thread but if I recall correctly there was only a corrupt patch that I cannot use, so somebody would need to send a patch that actually applies. With a patch that applies, I can tweak the log message with acked-by etc. just fine. Thanks.
