Hi Denton, On Tue, 1 Oct 2019, Denton Liu wrote: > Sorry for not replying or rolling this in earlier, I was waiting for > my series to hit master before doing this change but I guess it > doesn't really hurt to do it any earlier. No worries, thank you for working on this! I wonder whether it would make sense to add a `hdr-check` to at least one macOS and on Windows job, too, so that we get some confidence in the non-Linux contributions. But that I _will_ leave to others ;-) > On Tue, Oct 01, 2019 at 04:16:26AM -0700, Johannes Schindelin via GitGitGadget wrote: > > From: Johannes Schindelin <johannes.schindelin@xxxxxx> > > > > Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx> > > --- > > azure-pipelines.yml | 2 +- > > ci/install-dependencies.sh | 3 ++- > > ci/run-static-analysis.sh | 3 +++ > > 3 files changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/azure-pipelines.yml b/azure-pipelines.yml > > index c329b7218b..15831f6006 100644 > > --- a/azure-pipelines.yml > > +++ b/azure-pipelines.yml > > @@ -354,7 +354,7 @@ jobs: > > test "$GITFILESHAREPWD" = '$(gitfileshare.pwd)' || ci/mount-fileshare.sh //gitfileshare.file.core.windows.net/test-cache gitfileshare "$GITFILESHAREPWD" "$HOME/test-cache" || exit 1 > > > > sudo apt-get update && > > - sudo apt-get install -y coccinelle && > > + sudo apt-get install -y coccinelle coccinelle libcurl4-openssl-dev libssl-dev libexpat-dev gettext && > > Seems like you accidentally included coccinelle twice. Good point (copy-edit fail!). I force-pushed a fixed version, and will probably send out a new version tomorrow or Friday. Thanks, Dscho > > Anyway, thanks for picking up where I left off. > > -Denton > > > > > export jobname=StaticAnalysis && > > > > diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh > > index 8cc72503cb..8ce9ce276e 100755 > > --- a/ci/install-dependencies.sh > > +++ b/ci/install-dependencies.sh > > @@ -49,7 +49,8 @@ osx-clang|osx-gcc) > > ;; > > StaticAnalysis) > > sudo apt-get -q update > > - sudo apt-get -q -y install coccinelle > > + sudo apt-get -q -y install coccinelle libcurl4-openssl-dev libssl-dev \ > > + libexpat-dev gettext > > ;; > > Documentation) > > sudo apt-get -q update > > diff --git a/ci/run-static-analysis.sh b/ci/run-static-analysis.sh > > index a19aa7ebbc..65bcebda41 100755 > > --- a/ci/run-static-analysis.sh > > +++ b/ci/run-static-analysis.sh > > @@ -26,4 +26,7 @@ then > > exit 1 > > fi > > > > +make hdr-check || > > +exit 1 > > + > > save_good_tree > > -- > > gitgitgadget >
