On 26/09/19 10:46AM, Thomas Klaeger via GitGitGadget wrote: > From: Thomas Klaeger <thklaeger@xxxxxxxxx> > > Git for Windows 2.x ships with an executable that starts the Git Bash > with all the environment variables and what not properly set up. It is > also adjusted according to the Terminal emulator option chosen when > installing Git for Windows (while `bash.exe --login -i` would always > launch with Windows' default console). > > So let's use that executable (usually C:\Program Files\Git\git-bash.exe) > instead of `bash.exe --login -i` if its presence was detected. > > This fixes https://github.com/git-for-windows/git/issues/490 > > Signed-off-by: Thomas Kläger <thomas.klaeger@xxxxxx> While applying the patch, my patch check script complained that the author did not sign off. Well, they did... but with a slightly different name (Kläger vs Klaeger) and a completely different email address. I'm not sure if I can do something about it, just thought it was something worth mentioning. -- Regards, Pratyush Yadav
