On 26/09/2019 14:36, Derrick Stolee wrote:
How about 'Both'. We can't assume all contributors have Coccinelle on their OS/system.Another good reason to use "sizeof(var)" instead of sizeof(type)". :)That is indeed a very good reason, in addition to getting the type right automatically (by virtue of letting the compiler pick it). Should we make this an explicit guideline in our documentation?Better yet: can we create a Coccinelle script to fix it automatically? -Stolee
Philip