On Fri, Sep 20, 2019 at 11:36:09AM +0200, SZEDER Gábor wrote: > Ignoring everything but sources has the drawback that building an > older version of Git (e.g. during bisecting) creates all those > executables, and after going back to e.g. current 'master' the usual > cleanup commands like 'make clean' or 'git clean -fd' don't remove > them (the former doesn't know about them, and the latter doesn't > remove ignored files). Good reasoning. I've definitely been bit by this before when manually testing something (for some reason, I still haven't trained my fingers to type "test-tool foo" instead of "test-foo"). A similar one that bites me sometimes is that modern t5801 will fail with an old built version of git-remote-testgit. That one _is_ correctly handled in .gitignore, but you do have to remember to run "git clean". But that's the best we can do, I think, unless we want to make t5801 more paranoid about running the version from t/t5801/git-remote-testgit. > So let's ignore only the executable files under 't/helper/, i.e. > 'test-tool' and the three other remaining executables that could not > be integrated into 'test-tool' (no need to ignore object files, as > they are already ignored by our toplevel '.gitignore'). Sounds like the right solution, and the patch looks good to me. -Peff
