Commit 1/2: t0028: fix test for UTF-16-LE-BOM Commit 2/2: t0028: add more tests Please refer to individual commit messages for more information. Alexandr Miloslavskiy (2): t0028: fix test for UTF-16-LE-BOM t0028: add more tests t/t0028-working-tree-encoding.sh | 41 +++++++++++++++++++++++++++++++- 1 file changed, 40 insertions(+), 1 deletion(-) base-commit: 4c86140027f4a0d2caaa3ab4bd8bfc5ce3c11c8a Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-347%2FSyntevoAlex%2F%230189_t0028_fixes-v2 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-347/SyntevoAlex/#0189_t0028_fixes-v2 Pull-Request: https://github.com/gitgitgadget/git/pull/347 Range-diff vs v1: 1: fe850a8cd5 ! 1: d717a60932 t0028: fix test for UTF-16-LE-BOM @@ -2,12 +2,12 @@ t0028: fix test for UTF-16-LE-BOM - According to its name, the test its designed for UTF-16-LE-BOM. + According to its name, the test is designed for UTF-16-LE-BOM. However, possibly due to copy&paste oversight, it was using UTF-32 file. While the test succeeds (probably interprets extra \x00\x00 as embedded zero), I myself had an unrelated problem which caused the test to fail. - When analyzing the failure I was quite puzzled by the fact that the + When analyzing the failure I was quite puzzled by the fact that the test is obviously bugged. And it seems that I'm not alone: https://public-inbox.org/git/CAH8yC8kSakS807d4jc_BtcUJOrcVT4No37AXSz=jePxhw-o9Dg@xxxxxxxxxxxxxx/T/#u 2: d5f6f00a51 = 2: 40e54cf5ce t0028: add more tests -- gitgitgadget
