On 2019-09-15 at 22:05:55, SZEDER Gábor wrote:
> On Sun, Sep 15, 2019 at 09:26:21PM +0000, brian m. carlson wrote:
> > > > diff --git a/ci/test-documentation.sh b/ci/test-documentation.sh
> > > > index d49089832d..b3e76ef863 100755
> > > > --- a/ci/test-documentation.sh
> > > > +++ b/ci/test-documentation.sh
> > > > @@ -8,6 +8,8 @@
> > > > filter_log () {
> > > > sed -e '/^GIT_VERSION = /d' \
> > > > -e '/^ \* new asciidoc flags$/d' \
> > > > + -e '/stripped namespace before processing/d' \
> > > > + -e '/Attributed.*IDs for element/d' \
> > >
> > > I haven't seen this latter message in the CI builds, neither with
> > > Asciidoctor v1.5.8 nor with v2. Do we really need this filter, then?
> > > Where does this message come from?
> >
> > I see it and it definitely fails on my system without it. It comes from
> > libxslt, which has been patched in Debian to produce deterministic IDs.
> > I suspect we may not have seen it on Ubuntu systems because they are
> > running 16.04, which is likely older than the patch. If Travis updates
> > to 18.04, we may be more likely to have a problem.
>
> Thanks. Indeed, I kicked off a Travis CI build using their Ubuntu
> 18.04 image, and that "Attributed..." message was there.
>
> I think this future-proofing is a good idea, but I also think that
> this should be clarified in the commit message.
I can do that. I just noticed it failed on my laptop and added it,
assuming it was the stylesheets. I had to search Google for the output
to find out that it was libxslt.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
Attachment:
signature.asc
Description: PGP signature
