On 15/09/19 02:07AM, David wrote: > On Sat, 14 Sep 2019 at 06:51, Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx> wrote: > > On Fri, Sep 13, 2019 at 4:32 PM Pratyush Yadav <me@xxxxxxxxxxxxxxxxx> wrote: > > > On 13/09/19 12:24PM, Allan Ford wrote: > > > > I miss a general problem description: Whats wrong with the > > single-click on the icon to begin with? > > No problem here, but see my other message for further thoughts. > > > I consider adding a second way as not not acceptable. I also consider > > double-click on a file in a GUI an "open" action. > > Yes! > > In fact, I've often fantasized how useful it would be that if I double > clicked on that file name in the unstaged pane or the staged pane, > then that would open the file for editing in my preferred/configured editor. > > Now for me *that* would be a very frequently used improvement! > > I wonder what other readers think about this idea? Sounds reasonable. I've wanted something similar, but for commit messages. But one major reason I didn't come up with a patch for editing commit messages in the editor of your choice is terminal based editors. I don't think there is any way of finding out the default terminal emulator in Linux, and I don't think there is a standard way of making terminal emulator launch programs you want. So your suggestion works only for GUI based editors. We would have to mention that only GUI based editors can open files. I like the idea, but I thought I'd point a problem I saw with this feature. Also, the file viewer in git-gui opens the blame viewer, but I suppose that's not what most people want. -- Regards, Pratyush Yadav
