On Fri, Sep 13, 2019 at 03:29:00PM -0700, Junio C Hamano wrote: > This comment has nothing to do with the change, but the way the > patch is presented is quite hard to follow, in that the preimage or > the common context lines do not help understand what the new code is > doing at all ;-) > > I'll come back to the remainder of the patch later. Thanks. I applaud Christian's effort to tease it out into separate patches. I think I may need to take a pass and try to explain what's going on in some of them (which will definitely involve paging in some ancient work mentally, but hopefully between my memory and general familiarity with the area, I can massage it into something a bit more understandable). -Peff