On 12/09/19 08:05AM, Birger Skogeng Pedersen wrote: > Hi Pratyush, > > On Wed, Sep 11, 2019 at 10:55 PM Pratyush Yadav <me@xxxxxxxxxxxxxxxxx> wrote: > > Also, I notice that the bindings for other letters have the same > > function bound for both small and capital letters (IOW, same behavior > > with shift held and released). > > > > I don't necessarily think that is a great idea. It is a pretty common > > pattern to have, say Ctrl+a, do something, and Ctrl+Shift+a, do > > something else. Just want to pick your brain on whether you think we > > should do the same thing for both Ctrl+e and for Ctrl+E (aka > > Ctrl+Shift+e), or just bind it to Ctrl+e, and leave Ctrl+E for something > > else. > > I just tested what happens when you press Ctrl+e while Caps Lock is > enabled; the Ctrl+e binding is not invoked. That's probably why other > key bindings have the same function bound for both lower- and > upper-case letters, to have the same behaviour with/without Caps Lock > enabled. With that in mind, we should probably bind Ctrl+E aswell. Nice catch! Makes sense to have the same behaviour for both caps lock enabled and disabled. > > Should I create and send a new patch? Yes, please do. -- Regards, Pratyush Yadav
