On Thu, Sep 12, 2019 at 01:06:20PM +0200, SZEDER Gábor wrote: > > > +# - we must use protocol v2, because it handles the "have" negotiation before > > > +# processing the shallow direectives > > s/ee/e/ Thanks, fixed. > We can't simply replace that 'git config' command with 'test_config', > because it is implemented using 'test_when_finished', which doesn't > work in a subshell [1]. What we could do is: > > test_create_repo shallow-since-graph && > test_config -C shallow-since-graph core.commitGraph true && > ( > cd shallow-since-graph && > .... > > Or we could entirely avoid the subshell by passing '-C > shallow-since-graph' to every single command... [2] > > However, since this repo was specifically created for this test, it > doesn't really matter in what state it's left behind, so I don't think > it's worth it. Yep, agreed on all of this. :) -Peff
