Hi Pratyush, On Tue, Sep 10, 2019 at 9:12 PM Pratyush Yadav <me@xxxxxxxxxxxxxxxxx> wrote: > This patch LGTM, but I'm not sure how to resolve the keybindings > problem. Junio suggested we have configurable keybindings, and I agree > with him, but until we do, something has to be agreed upon. And we also > need to come up with a reasonable default. > > So, I don't have any preferences for either using Alt+3 for the commit > message buffer, or Alt+4. Unless someone has objections, I'll go with > Alt+3 for the commit message buffer, and Alt+4 for the diff. I honestly don't quite follow the argumentation to use Alt+3 for the commit message widget. Is Alt+4 (really) too awkward? And if it is, how is Alt+3 better? If you want to see it merged now (which I do, too), I propose we leave it at Alt+3 for the diff, and Alt+4 for the commit message buffer. As David A. mentioned in his email[1], git-cola utilizes CTRL+J/K/L for navigation, maybe we should consider(?): Alt+i: focus unstaged Alt+j: focus staged Alt+k: focus commit widget Alt+l: focus diff view [1] https://public-inbox.org/git/20190910085446.GB32239@xxxxxxxxx/#t Best regards, Birger
