Re: gitk problems: can't unset "idinlist(...)"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Sat, 21 Jul 2007, Jeff King wrote:
> 
> I just independently came to the same conclusion. Your patch looks
> correct to me (though there are some unrelated formatting changes which
> made it a little harder to read).

Yeah, I shouldn't have done that - I just ended up changing the "for()" to 
a "while()" (because we should *not* do the same thing at the end of the 
loop each time).  And as a part of that I changed the initialization to be 
at the head of the while-loop rather than in the variable declaration, 
because that's how I tend to mostly write while-loops.

But I probably should have tried to keep the patch minimal instead, so 
that it would show the changes better. Probably not a big deal.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux