On Tue, Sep 3, 2019 at 7:15 PM Pratyush Yadav <me@xxxxxxxxxxxxxxxxx> wrote: > > On 02/09/19 09:13PM, Bert Wesarg wrote: > > On Mon, Sep 2, 2019 at 9:03 PM Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx> wrote: > > > > [snip] > > > > On second thought, wouldn't it make more sense to expand the > > > > commit > > > > message buffer instead? The point of resizing that pane is to see more > > > > of the commit message. So it makes more sense to make the commit message > > > > buffer take up all the vertical space, rather than making the scrollbar > > > > move. > > > > > > it is, I just broke that ;-) > > > > is fixed in GitHub: > > > > wget https://github.com/bertwesarg/git-gui/commit/56163547604f44688e208393f8941efaf5247d40.patch > > I tried the patch out. Works fine on Linux. Thanks. > > There is a minor typo in your commit message. > > > Sugestted-by: Birger Skogeng Pedersen <birger.sp@xxxxxxxxx> > > s/Sugestted/Suggested/ > > > Signed-off-by: Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx> > > One more observation: > > If I write a particularly long line (and consequently the scrollbar > becomes active), and then hit Ctrl+A to select all text, and then > backspace to delete it all, the scrollbar does not get updated. It still > shows the old position where is is "scrolled" halfway through. As soon > as I type in any other character, it takes the correct state, and > becomes disabled. > > The vertical scrollbar behaves correctly in this scenario, and does take > the correct state and position as soon as I delete all text, so I > suspect it should be a small fix. Maybe a missed option or something > like that? While I can reproduce this, I don't figured out what is wrong here. I tried a minimal example and this also fails. The yScrollCommand is issued, but the xScrollCommand not. I have tcl/tk 8.6.8 on Linux. Bert > > -- > Regards, > Pratyush Yadav
