Thomas Gummerer <t.gummerer@xxxxxxxxx> writes: > On 08/30, Junio C Hamano wrote: >> Martin Ågren <martin.agren@xxxxxxxxx> writes: >> ... >> > The above makes me think that once this new function is in good shape, >> > the commit introducing it could sell it as "this is hard to get right -- >> > let's implement it correctly once and for all". ;-) >> >> Yes, that is a more severe issue. > > With this do you mean what you quoted above, or that the lockfile is > not rolled back? I agree that the lockfile not being rolled back if > 'refresh_cache()' fails is indeed the bigger issue, and I'll fix that > in v3. I can also add something like the above to the commit message, > just wanted to make sure I'm not missing something subtle in what you > quoted above. You didn't miss anything, other than that I trimmed my quote too much and ended up confusing you. Thanks.
