Re: feature request, git-gui: add hotkey to toggle amend/new

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pratyush,


On Tue, Sep 3, 2019 at 2:45 PM Pratyush Yadav <me@xxxxxxxxxxxxxxxxx> wrote:
> Can you try doing a Shift+Tab? For me on Linux, if I hit Shift+Tab, it
> immediately takes me to the "Amend last commit" option. Then I can press
> space to select it and Tab again to get back to the commit message.

It seems that Shift+Tab doesn't do anything (on Windows 10).
Regardless, imo there should be a binding dedicated to toggle amend.


> Also, since we are on this topic, how about making the "Amend last
> commit" button a toggle instead? This would act as a "turn amend mode
> on/off" button. Since "Amend last commit" and "New Commit" are mutually
> exclusive, a single toggle to switch between those modes makes sense to
> me.

I assume you're talking about the button in the "Commit" dropdown
menu. I agree, it could be just a single entry which is a toggle to
enable/disable amending. And (above the commit message dialog) perhaps
just a single checkbox; "Amend Last Commit". In other git GUIs (Git
Cola and TortoiseGit) I see they're using just a single checkbox for
this option. But maybe that is a slightly different topic, the hotkey
behaviour would remain the same.


> ... do you still feel the need for a dedicated binding for amends?

How do you guys feel about it? So far it seems we're at two "yay" and
one "nay". I really feel it is in the best interest of the git-gui
project to implement this hotkey. And not just because it is my
personal preference to have it :-)


Birger



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux