On Tue, 3 Sep 2019 at 04:11, Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx> wrote: > On Mon, Sep 2, 2019 at 6:25 PM Birger Skogeng Pedersen <birger.sp@xxxxxxxxx> wrote: > > On Sat, Aug 31, 2019 at 12:51 PM Birger Skogeng Pedersen <birger.sp@xxxxxxxxx> wrote: > > > In my pursuit to fully utilize git-gui with only using a keyboard, I > > > suggest that there is a hotkey to toggle between selecting "New > > > Commit" and "Amend Last Commit". Hi, thanks for maintaining and contributing to git and git-gui, it's a great tool! > After focusing the commit message widget, you can focus the radio > buttons with Tab/Shift+Tab and press Space. > I think this is short enough, so that wasting a Letter is not > justified here. Ugh, may I express how unhappy I am to read that opinion from the maintainer. I strongly disagree, please reconsider :( And I enthusiastically support this initial request for a single hotkey to immediately toggle between "New Commit" and "Amend Last Commit". And it should work regardless of wherever the cursor or highlight is currently active. I have used git-gui for many years and I find this is actually the most annoying and inconsistent aspect of its user interface. Sometimes if one is lucky then "spacebar" will achieve it at startup or after refresh, sometimes not. When I test here just now the suggested tab/shift-tab/spacebar method, it does toggle but it also changes the items in the staged changes list as an unwanted side effect. My version says 0.20.0.8.gd000, but I have a few local patches (written years ago) so sorry I am not testing with a version that you have, but even so I wanted to report what I observed. If one is often amending commit messages as I do during large interactive rebases, it is painful to have to do some kind of context-sensitive multi-key dance just to change from "New Commit" to "Amend Last Commit". Especially when every other operation has become a single keystroke in my muscle memory. In my world it most definitely would not be "wasting a letter" to implement this! It would instead be "OMG at last that got fixed for everyone, hooray!" :D
