On 8/29/19 4:48 PM, Eric Sunshine wrote:
On Thu, Aug 29, 2019 at 7:12 PM Jon Simons <jon@xxxxxxxxxxxxx> wrote:
On 8/29/19 3:45 PM, Eric Sunshine wrote:
On Thu, Aug 29, 2019 at 6:38 PM Jon Simons <jon@xxxxxxxxxxxxx> wrote:
+ test_write_lines /* >sparse-src/all-files &&
Hmm, does this work correctly? I would expect the /* to expand to all
names at the root of your filesystem, which isn't what you want. You
want the literal string "/*", which means you should quote it (with
double quotes inside the test body). [...]
Oof, thanks -- yes, this is incorrect. I will revert this back to
'echo'. I misapplied your initial suggesttion to all three lines.
Curious. Did the test still pass even with the unquoted "/*"? If so,
does that indicate a flaw in the test or somewhere else?
Yes, the test also passes with the unquoted "/*". I think this showcases
that the test really is a bare minimal sanity check that clones providing
a sparse filter argument are able to run to completion. As-is the test
does not further assert any behavior of the filter, just that the BUG is
avoided.
-Jon
