Hi Elijah, On Fri, 23 Aug 2019, Elijah Newren wrote: > On Thu, Aug 22, 2019 at 8:01 PM Eric Wong <e@xxxxxxxxx> wrote: > > > > Elijah Newren <newren@xxxxxxxxx> wrote: > > > * Remove git-filter-branch from git.git. Mention in the release > > > notes where people can go to get it.[1] > > > > > > filter-branch is not merely a slow or difficult-to-use tool, it's one > > > that *fosters* mistakes by making it hard to get things right in > > > several different ways. Granted, people exercise extra caution using > > > filter-branch because they know they need to, but there are so many > > > gotchas that they're likely to accidentally mess something up. Those > > > mess-ups are not always discovered immediately, and by then it's > > > nearly cast into stone (rewriting being something you want to do very > > > rarely). > > > > Is it possible to turn git-filter-branch into a fast, compatible, > > and (maybe) safe wrapper for git-filter-repo? That would "fix" > > filter-branch and (if done carefully) not break existing uses. > > Ooh, what an interesting question. I can probably ramble on a LOT > longer than you expected about this... > > [...] FWIW if anybody cares about my opinion: I would be totally fine with integrating git-filter-repo into git.git, have it there for a major version or two, then patch `git filter-branch` to spew out a deprecation warning, and then remove that latter command a major version (or two) later. Ciao, Dscho
