On Mon, Aug 26, 2019 at 04:50:13PM -0400, Jeff King wrote: > On Sun, Aug 18, 2019 at 12:03:17PM -0400, Theodore Y. Ts'o wrote: > > > I was trying to run "make profile" on the master branch (commit > > 5fa0f5238b: "Git 2.23") and it died in the > > > > $(MAKE) PROFILE=GEN perf > > > > dies with: > > > > cannot open test-results/p5302-pack-index.subtests: No such file or directory at ./aggregate.perl line 153. > > > > I presume that's becuase the file t/perf/test-results/p5302-pack-index.subtests is missing? > > That file should be created by running p5302. If you do: > > cd t/perf > rm -rf test-results > ./run p5302-pack-index.sh > > is it generated? No, it wasn't. See below.... - Ted <tytso@lambda> {/usr/projects/git/git-core/t/perf} (master) 1140% git show commit 5fa0f5238b0cd46cfe7f6fa76c3f526ea98148d9 (HEAD -> master, tag: v2.23.0, origin/master, origin/HEAD) Author: Junio C Hamano <gitster@xxxxxxxxx> Date: Fri Aug 16 10:28:23 2019 -0700 Git 2.23 Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN index 551e607e73..a1539a7ce6 100755 --- a/GIT-VERSION-GEN +++ b/GIT-VERSION-GEN @@ -1,7 +1,7 @@ #!/bin/sh GVF=GIT-VERSION-FILE -DEF_VER=v2.23.0-rc2 +DEF_VER=v2.23.0 LF=' ' <tytso@lambda> {/usr/projects/git/git-core/t/perf} (master) 1141% rm -rf test-results ; ./run p5302-pack-index.sh === Running 1 tests in this tree === warning: $GIT_PERF_LARGE_REPO is $GIT_BUILD_DIR. warning: This will work, but may not be a sufficiently large repo warning: for representative measurements. not ok 1 - repack # # git repack -ad && # PACK=$(ls .git/objects/pack/*.pack | head -n1) && # test -f "$PACK" && # export PACK # cannot open test-results/p5302-pack-index.subtests: No such file or directory at ./aggregate.perl line 153. <tytso@lambda> {/usr/projects/git/git-core/t/perf} (master) 1142% git status On branch master Your branch is up to date with 'origin/master'. Untracked files: (use "git add <file>..." to include in what will be committed) ../../MAKELOG ../../MAKELOG.1 ../../common-cmds.h ../../git-lost-found ../../git-peek-remote ../../git-rebase--am ../../git-rebase--common ../../git-rebase--helper ../../git-rebase--interactive ../../git-rebase--merge ../../git-relink ../../git-remote-testgit ../../git-repo-config ../../git-tar-tree ../../git_remote_helpers/ ../../perl/MYMETA.json ../../perl/MYMETA.yml ../../perl/PM.stamp ../../perl/blib/ ../../perl/perl.mak ../../perl/pm_to_blib ../../test-chmtime ../../test-config ../../test-credential ../../test-ctype ../../test-date ../../test-delta ../../test-dump-cache-tree ../../test-dump-split-index ../../test-dump-untracked-cache ../../test-fake-ssh ../../test-genrandom ../../test-hashmap ../../test-index-version ../../test-line-buffer ../../test-match-trees ../../test-mergesort ../../test-mktemp ../../test-obj-pool ../../test-parse-options ../../test-path-utils ../../test-prio-queue ../../test-read-cache ../../test-regex ../../test-revision-walking ../../test-run-command ../../test-scrap-cache-tree ../../test-sha1 ../../test-sha1-array ../../test-sigchain ../../test-string-list ../../test-string-pool ../../test-submodule-config ../../test-subprocess ../../test-svn-fe ../../test-treap ../../test-urlmatch-normalization ../../test-wildmatch nothing added to commit but untracked files present (use "git add" to track)