On Thu, Aug 22, 2019 at 01:18:08PM -0700, Junio C Hamano wrote: > Denton Liu <liu.denton@xxxxxxxxx> writes: > > > While we're at it, perform some major cleanup of t4014 including some > > stylistic cleanup and also, unmasking of Git return codes. > > Wow. It seems that "while we're at it" grew quite large and (from > purely patch count's point of view) ends up appearing as if it were > the primary focus of the series ;-) For housekeeping, since this patchset now exists as two branches (dl/format-patch-cover-letter-subject and dl/format-patch-doc-test-cleanup), would you prefer any new revisions exist as one big patchset or two separate patchsets targeting each individual branch? > > Thanks for tackling the age-old mess. Admittedly, this particular > script is from the older parts of Git's history and a clean-up was > long overdue. > > With the "split pipes" approach taken in patches 09 and 10, we'd end > up leaving more untracked and unignored cruft in the working tree. I > do not think they would cause problems with the existing tests after > reading the patches over. > >
