Re: [PATCH v3 10/13] t4014: stop losing return codes of git commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v3 10/13] t4014: stop losing return codes of git commands
From: Johannes Sixt <j6t@xxxxxxxx>
Date: Tue, 20 Aug 2019 21:04:22 +0200
Cc: Git Mailing List <git@xxxxxxxxxxxxxxx>, Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>, Junio C Hamano <gitster@xxxxxxxxx>, Eric Sunshine <sunshine@xxxxxxxxxxxxx>
In-reply-to: <20190820073130.GA32049@archbookpro.localdomain>
References: <cover.1566258525.git.liu.denton@gmail.com> <cover.1566285151.git.liu.denton@gmail.com> <64069c0c540b109b46b2cc6c90e3b5c912aa18c5.1566285151.git.liu.denton@gmail.com> <20190820073130.GA32049@archbookpro.localdomain>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

Am 20.08.19 um 09:31 schrieb Denton Liu:
> Oops, this should read
> 
> 	git_version="$(git --version >version && sed "s/.* //" <version)"

sed is not necessary. Make that

	git_version=$(git --version) &&
	git_version=${git_version##* }

-- Hannes

References:
- [PATCH v2 0/4] format-patch: learn --infer-cover-subject option
  - From: Denton Liu
- [PATCH v3 00/13] format-patch: learn --infer-cover-subject option (also t4014 cleanup)
  - From: Denton Liu
- [PATCH v3 10/13] t4014: stop losing return codes of git commands
  - From: Denton Liu
- Re: [PATCH v3 10/13] t4014: stop losing return codes of git commands
  - From: Denton Liu

Prev by Date: Re: [PATCH 2/3] Doc: add more detail for git-format-patch
Next by Date: Re: [PATCH] t0021: make sure clean filter runs
Previous by thread: Re: [PATCH v3 10/13] t4014: stop losing return codes of git commands
Next by thread: [PATCH v3 11/13] Doc: add more detail for git-format-patch
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]