Re: [PATCH v3 1/6] rebase -i: add --ignore-whitespace flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Phillip

On Wed, Aug 21, 2019 at 12:10 AM Phillip Wood <phillip.wood123@xxxxxxxxx> wrote:
>
> Thanks for spelling out exactly what this does. I had not appreciated
> the difference before. Does this mean that if I have a branch with some
> whitespace cleanups I'll get different results if I rebase it with the
> sequencer compared to am? (I suspect from the description that the
> sequencer will simply ignore all my whitespace changes)

I'm afraid that this is the case.

> I think this is ready if we can live with the difference - I'm not
> entirely convinced that adding an option with the same name and a
> different behavior is going to improve things though.

This is the first step to improving consistency. We can
further improve upon the implementation. I have already
mentioned that in the cover letter of previous patches[1].

Thanks
Rohit

[1]: https://public-inbox.org/git/20190712185015.20585-1-rohit.ashiwal265@xxxxxxxxx/



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux