Re: [PATCH guilt] Handles slashes in branch names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 19, 2007 at 11:35:11AM -0700, Eric Lesh wrote:
> When a branch name has a slash and autotagging is enabled, guilt barfs
> when updating the stack tags.  Escape the branch name in the tags to
> allow this to work.
...
> -		git-rev-parse HEAD > "$GIT_DIR/refs/tags/${branch}_top"
> -		head -1 < $applied | cut -d: -f1 > "$GIT_DIR/refs/tags/${branch}_bottom"
> -		git-rev-parse $(head -1 < $applied | cut -d: -f1)^ > "$GIT_DIR/refs/tags/${branch}_base"
> +		git-rev-parse HEAD > "$GIT_DIR/refs/tags/${newbranch}_top"
> +		head -1 < $applied | cut -d: -f1 > "$GIT_DIR/refs/tags/${newbranch}_bottom"
> +		git-rev-parse $(head -1 < $applied | cut -d: -f1)^ > "$GIT_DIR/refs/tags/${newbranch}_base"

Why mangle the branch name when we can do:

mkdir -p `basename $GIT_DIR/refs/tags/${branch}_top`
git-rev-parse .... 

Sure, it is ugly, but it preserves the branch name. Am I missing something?

Josef 'Jeff' Sipek.

-- 
A computer without Microsoft is like chocolate cake without mustard.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux